Patch: xmlrpclib client ignores datetime tzinfo when creating iso8601 dates

[lclark]

BPO	2623
Files	xmlrpclib-timezone.patch: Patch for xmlrpclib.py, adds iso8601 with timezone info

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2008-04-12.06:11:48.707>
labels = ['expert-XML', 'type-bug']
title = 'Patch: xmlrpclib client ignores datetime tzinfo when creating iso8601 dates'
updated_at = <Date 2013-03-20.20:56:25.330>
user = 'https://bugs.python.org/lclark'

bugs.python.org fields:

activity = <Date 2013-03-20.20:56:25.330>
actor = 'Thomas Fenzl'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['XML']
creation = <Date 2008-04-12.06:11:48.707>
creator = 'lclark'
dependencies = []
files = ['10016']
hgrepos = []
issue_num = 2623
keywords = ['patch']
message_count = 4.0
messages = ['65394', '65688', '65697', '184795']
nosy_count = 3.0
nosy_names = ['schmir', 'lclark', 'Thomas Fenzl']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2623'
versions = ['Python 2.7', 'Python 3.2']

[lclark]

xmlrpclib ignores datetime parameter timezone information. Two spots
were identified to apply a new formatting function, _iso8601format, to
ensure that the timezone is passed to the server.

I would like this fix to be included in future releases. (Thank you!)

[smontanaro]

Leonard,

Can you reformulate your patch in terms of the current xmlrpclib module
code? It no longer applies cleanly. Also, to be considered it will
definitely need new test cases and may well need documentation changes.

Also, note that the XML-RPC "spec" is notoriously vague. If you're
going to be messing about with the serialized form of datetime objects I
think you'll need to demonstrate that it doesn't break interoperability
with implementations for other languages.

[lclark]

While the XML-RPC spec is vague with regards to respecting time zone
information, the iso8601 document is not vague as to how to properly
serialize it.

Some XML-RPC libraries (like ours) completely ignore time zone
information. I will make every effort to test this against as many
libraries as I can.

While I'm at it, I'll see about adding support for time zone information
in server results.

[ThomasFenzl]

Is this still relevant?
The new xmlrcp.client still dumps both naive and aware datetimes as ISO 8601 strings without timezone information. xmlrpc.client.DateTime does not handle ISO 8601 with timezone information.

So if it is, it could be updated to using strings without timezone for naive datetimes and with timezone for aware. Not sure if that could break clients parsing the xml themselves.

[StanFromIreland]

The patch has been implemented (partly):

cpython/Lib/xmlrpc/client.py

Lines 251 to 256 in ea2d707

	def _iso8601_format(value):
	if value.tzinfo is not None:
	# XML-RPC only uses the naive portion of the datetime
	value = value.replace(tzinfo=None)
	# XML-RPC doesn't use '-' separator in the date part
	return value.isoformat(timespec='seconds').replace('-', '')

@vstinner noted that it is to be ignored, therefore, this can be closed.