Redefinition of HAVE_STRFTIME can cause compiler errors.

[rgpitts]

BPO	6820
Nosy	@amauryfa
Files	issue-6820.patch: pyconfig.h patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2009-09-02.09:39:44.063>
labels = ['build', 'OS-windows', '3.11']
title = 'Redefinition of HAVE_STRFTIME can cause compiler errors.'
updated_at = <Date 2021-08-07.10:54:14.082>
user = 'https://bugs.python.org/rgpitts'

bugs.python.org fields:

activity = <Date 2021-08-07.10:54:14.082>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2009-09-02.09:39:44.063>
creator = 'rgpitts'
dependencies = []
files = ['22710']
hgrepos = []
issue_num = 6820
keywords = ['patch']
message_count = 6.0
messages = ['92159', '92209', '99337', '140792', '223153', '236322']
nosy_count = 3.0
nosy_names = ['amaury.forgeotdarc', 'rgpitts', 'braden']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue6820'
versions = ['Python 3.11']

[rgpitts]

I'm working with the Python C API and omniOrb with Visual Studio 2008
on Windows XP.

A OmniOrb header corba_sys_dep.h is defining HAVE_STRFTIME as 1
...
#define HAVE_STRFTIME 1
...

pyconfig.h is then defining this again. 
...
#define HAVE_STRFTIME
...

This is raising a compiler warning and then multiple syntax errors in
math.h depending on the order of inclusion of these headers. If the
pyconfig.h is included after corba_sys_dep.h multiple syntax errors.
However if it is included before only a warning is raised.

I think pyconfig.h needs changing to
#ifndef HAVE_STRFTIME
#define HAVE_STRFTIME
#endif

[amauryfa]

Those HAVE_XXX symbols should be defined like autoconf does:
#define HAVE_STRFTIME 1
This is what happens on Unix platforms, and AFAIK this plays well with
other libraries which define the same symbols.

[braden]

In general, this does *not* play well with libraries that define the same symbols.

It is not correct to install the AC_CONFIG_HEADERS. Any macros in an installed configuration header need to be namespaced per-project; e.g., PYTHON_HAVE_STRFTIME.

[rgpitts]

As Python 2.6 is now security only and 2.7 is last major release I've patched this against Python 3.2 because pyconfig.h hadn't changed much since 2.6.

I've done as Amaury suggested and changed the HAVE_XXX symbols to define 1 like autoconf. 'make patchcheck' has fixed some general formatting issues included in the patch.

[BreamoreBoy]

There is no way that I'm commenting on the patch as it's against pyconfig.h, what do our experts think of this?

[BreamoreBoy]

Having had another look the patch is not acceptable as the majority of the changes are to whitespace only.