posixmodule.c redefines FSTAT

[alanh]

BPO	10898
Nosy	@pitrou, @tiran

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2011-01-12.18:32:13.426>
labels = ['extension-modules', 'build', '3.8', '3.9', '3.10']
title = 'posixmodule.c redefines FSTAT'
updated_at = <Date 2020-11-15.23:37:24.137>
user = 'https://bugs.python.org/alanh'

bugs.python.org fields:

activity = <Date 2020-11-15.23:37:24.137>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2011-01-12.18:32:13.426>
creator = 'alanh'
dependencies = []
files = []
hgrepos = []
issue_num = 10898
keywords = []
message_count = 12.0
messages = ['126120', '126489', '126490', '126527', '139601', '139604', '139605', '139611', '139612', '139615', '139638', '139714']
nosy_count = 4.0
nosy_names = ['pitrou', 'christian.heimes', 'alanh', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'remind'
stage = 'resolved'
status = 'open'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue10898'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[alanh]

Python 2.7.1 redefines FSTAT, but the problem is my libc already defines FSTAT in sys/ioctl.h.

I've worked around this by prefixing the FSTAT define with PYTHON. It should probably be done with STAT too.

--- Modules/posixmodule.c.old	2011-01-12 01:46:45.000000000 +0000
+++ Modules/posixmodule.c	2011-01-12 01:47:05.000000000 +0000
@@ -344,11 +344,11 @@
 #undef STAT
 #if defined(MS_WIN64) || defined(MS_WINDOWS)
 #       define STAT win32_stat
-#       define FSTAT win32_fstat
+#       define PYTHON_FSTAT win32_fstat
 #       define STRUCT_STAT struct win32_stat
 #else
 #       define STAT stat
-#       define FSTAT fstat
+#       define PYTHON_FSTAT fstat
 #       define STRUCT_STAT struct stat
 #endif
 
@@ -6641,7 +6641,7 @@
     if (!_PyVerify_fd(fd))
         return posix_error();
     Py_BEGIN_ALLOW_THREADS
-    res = FSTAT(fd, &st);
+    res = PYTHON_FSTAT(fd, &st);
     Py_END_ALLOW_THREADS
     if (res != 0) {
 #ifdef MS_WINDOWS

[pitrou]

How about adding "#undef FSTAT" instead? Would it work for you?

[alanh]

On Tue, 2011-01-18 at 19:59 +0000, Antoine Pitrou wrote:

Antoine Pitrou <pitrou@free.fr> added the comment:

How about adding "#undef FSTAT" instead? Would it work for you?

Sure.

Alan.

[pitrou]

Ok, fixed in r88111 (3.2), r88112 (3.1) and r88113 (2.7).

[alanh]

Hi Antoine,

Unfortunately the #undef is too early and later #includes redefine it.

We should move the #undef closer to the code that actually uses them.

[python-dev]

New changeset 45b27448f95c by Antoine Pitrou in branch '2.7':
Really fix issue bpo-10898: posixmodule.c redefines FSTAT
http://hg.python.org/cpython/rev/45b27448f95c

[pitrou]

Ah, sorry. Can you check with the changeset I've just pushed (it's on branch 2.7)?
If ok, I'll port it to 3.2/3.x and close again.

[alanh]

No, that patch still doesn't work.

[pitrou]

Hum, can you propose something?

[alanh]

I've had to split the three #undef's up to just before they're used.

[pitrou]

I've had to split the three #undef's up to just before they're used.

I would really prefer to move up the offending #include rather than
sprinkle those #undef's all over the place.