Better error messages for wsgiref validator failures

[Sidnicious]

BPO	14652
Nosy	@berkerpeksag, @Sidnicious
Files	ssm_validate.patch ssm_validate.patch: Don’t use tuples when using only len() to format a string issue14652.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2012-04-23.17:48:02.699>
labels = ['type-feature', 'library']
title = 'Better error messages for wsgiref validator failures'
updated_at = <Date 2015-02-13.19:23:25.772>
user = 'https://github.com/Sidnicious'

bugs.python.org fields:

activity = <Date 2015-02-13.19:23:25.772>
actor = 'berker.peksag'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2012-04-23.17:48:02.699>
creator = 'ssm'
dependencies = []
files = ['25320', '25624', '38131']
hgrepos = []
issue_num = 14652
keywords = ['patch']
message_count = 4.0
messages = ['159053', '160951', '160971', '235914']
nosy_count = 3.0
nosy_names = ['mcjeff', 'berker.peksag', 'ssm']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14652'
versions = ['Python 3.4', 'Python 3.5']

[Sidnicious]

wsgiref’s validation middleware is missing messages for many of its assertions, and its docstring doesn’t reflect read() now requiring an argument (said that it took an optional argument).

Here’s a patch to add some and update the comment.

[mcjeff]

I went through the patch real quick and I noticed that your using single element tuples in your string formatting. That makes sense in situations where the argument might itself be a tuple, however, not on calls to len() as that will return an integer.

[Sidnicious]

Thanks Jeff, I’m actually a relatively new Python developer and got the impression that it was best practice to always use a tuple for string formatting, for consistency.

Here’s an updated patch which drops the tuples for those cases.

[berkerpeksag]

Here is an updated patch. For InputWrapper.read(), see bpo-18610.

[iritkatriel]

Marking as easy. The patch needs to be converted to a GitHub PR.