In pdb using "until X" doesn't seem to have effect in commands

[vyktor]

BPO	24140
Nosy	@birkenfeld, @xdegaye
Files	test.py minimal.py: Minmal reproducable example

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2015-05-07.11:31:04.988>
labels = ['type-bug', 'library']
title = 'In pdb using "until X" doesn\'t seem to have effect in commands'
updated_at = <Date 2015-05-09.19:41:21.063>
user = 'https://bugs.python.org/vyktor'

bugs.python.org fields:

activity = <Date 2015-05-09.19:41:21.063>
actor = 'xdegaye'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-05-07.11:31:04.988>
creator = 'vyktor'
dependencies = []
files = ['39326', '39327']
hgrepos = []
issue_num = 24140
keywords = []
message_count = 5.0
messages = ['242711', '242800', '242813', '242816', '242837']
nosy_count = 3.0
nosy_names = ['georg.brandl', 'xdegaye', 'vyktor']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24140'
versions = ['Python 3.2']

[vyktor]

When using pdb -m pdb test.py and entering:

(Pdb) b A.f
Breakpoint 1 at d:\tmp\stack\test.py:8
(Pdb) commands 2
(com) disable 2
(com) until 13
(com) end

Until doesn't seem to have any effect. When statement is executed manually, everything works as expected (execution halts before implicit return from function).

[xdegaye]

test.py is missing.

[vyktor]

Adding test.py, but according to docs https://docs.python.org/3.2/library/pdb.html#pdbcommand-commands

"Specifying any command resuming execution (currently continue, step, next, return, jump, quit and their abbreviations) terminates the command list (as if that command was immediately followed by end). "

This is probably expected behavior.

[vyktor]

In here:

/home/vyktor/src/error/minimal.py(1)<module>()
-> print('1')
(Pdb) break 2
Breakpoint 1 at /home/vyktor/src/error/minimal.py:2
(Pdb) commands 1
(com) print('Triggered bp 1')
(com) until 4
(com) end
(Pdb) cont
1
Triggered bp 1
/home/vyktor/src/error/minimal.py(2)<module>()
-> print('2')
(Pdb)

until has no effect.

Expected behavior would be executing print 2 and 3.

[xdegaye]

The bug occurs also on the default branch:
'3.5.0a4+ (default:8bac00eadfda, May 6 2015, 17:40:12) \n[GCC 4.9.2 20150304 (prerelease)]'

The reason is that 'do_until' is missing from the
Pdb.commands_resuming list, which causes the Pdb.bp_commands() method
to invoke the interaction function _cmdloop() after having processed
all the breakpoint commands instead of returning from the trace
function, so that the settings made by set_until() are lost.

[gaogaotiantian]

Fixed in #124401