Improvement mktime error reporting

[psijic]

BPO	44413
Nosy	@malemburg, @terryjreedy, @abalkin, @tiran, @pganssle, @corona10, @Fidget-Spinner, @akulakov, @wasade
PRs	bpo-44413: [Do Not Merge] Add mktime() test #30124

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-06-13.18:02:13.156>
labels = ['type-bug', '3.9', '3.10', '3.11']
title = 'Improvement mktime error reporting'
updated_at = <Date 2021-12-20.22:45:30.454>
user = 'https://bugs.python.org/psijic'

bugs.python.org fields:

activity = <Date 2021-12-20.22:45:30.454>
actor = 'wasade'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2021-06-13.18:02:13.156>
creator = 'psijic'
dependencies = []
files = []
hgrepos = []
issue_num = 44413
keywords = []
message_count = 15.0
messages = ['395758', '396102', '397600', '407346', '408615', '408627', '408642', '408644', '408650', '408658', '408659', '408660', '408977', '408978', '408979']
nosy_count = 10.0
nosy_names = ['lemburg', 'terry.reedy', 'belopolsky', 'christian.heimes', 'p-ganssle', 'corona10', 'kj', 'andrei.avk', 'psijic', 'wasade']
pr_nums = ['30124']
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue44413'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[psijic]

date_str = "2019-06-06 10:02:00"
    datetime_obj = datetime.strptime(date_str, "%Y-%m-%d %H:%M:%S")
    datetime_obj_utc1 = datetime_obj.replace(tzinfo=pytz.timezone("America/New_York"))
    datetime_obj_utc2 = pytz.timezone("America/New_York").localize(datetime_obj)
    print(datetime_obj_utc1, datetime_obj_utc2)
    ts1 = time.mktime(datetime_obj_utc1.timetuple())
    ts2 = time.mktime(datetime_obj_utc2.timetuple())

>>> Output:
    ts2 = int(time.mktime(datetime_obj_utc2.timetuple()))
OverflowError: mktime argument out of range

OS: Linux OpenSuse TW

[terryjreedy]

An exception is not a 'crash', as defined for this tracker. 3.8 only gets security fixes. A 3.9 or 3.10 test is needed and Windows does not have pytz.

[terryjreedy]

The posted code is incomplete, improperly indented, and a bit jumbled with respect to prompts. If the bug is real, it should be possible to reproduce without pytz. I do not have it on either Windows or macOS. Vyacheslav, can you post a better failing example?

[akulakov]

Cannot reproduce with 3.8.6 on MacOS. The code runs without any errors. As OP hasn't responded in 4 months I think we should close as "works for me".

[wasade]

I'd like to politely request this issue be reopened.

We recently observed a similar, if not the same, OverflowError during continuous integration using Github Actions on ubuntu-latest (20.04). We can produce the error using pure Python without pytz.

We have been unable to replicate the error using Github Actions on macos-latest, Centos 7.9, Ubuntu 18.04 or OSX 11.6.1.

Specifically, the following code, which I believe is pure python, will trigger the overflow. We've observed this using Python 3.7 and 3.9.

import time
print(time.mktime((2017,5,26,15,30,16,4,146,1)))

Exact error output from CI can be found at the link below:

https://github.com/biocore/microsetta-private-api/runs/4536611219?check_suite_focus=true#step:4:117

On a passing system, we receive "1495837816.0" as output. On a failing system, we observe "OverflowError: mktime argument out of range".

More detail can be found on our issue with pytz and stub42 who helped guide a more definitive example of the bug showing it could be pure Python. That issue can be found here:

stub42/pytz#66

Last, I apologize in advance if any detail is missing here or if this is not formatted as well as it should be. This is my first bug report with Python and am unfamiliar with the norms. Please let me know if further information may be helpful.

[akulakov]

Confirmed on Ubuntu buildbot:

https://github.com/python/cpython/runs/4537544103?check_suite_focus=true