socketserver.shutdown should stop serve_forever() immediately

[encukou]

BPO	44769
Nosy	@encukou

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-07-28.21:32:39.337>
labels = ['library']
title = 'socketserver.shutdown should stop serve_forever()  immediately'
updated_at = <Date 2021-07-29.07:21:46.545>
user = 'https://github.com/encukou'

bugs.python.org fields:

activity = <Date 2021-07-29.07:21:46.545>
actor = 'petr.viktorin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-07-28.21:32:39.337>
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 44769
keywords = []
message_count = 2.0
messages = ['398427', '398462']
nosy_count = 1.0
nosy_names = ['petr.viktorin']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue44769'
versions = []

Linked PRs

• gh-88932 socketserver.shutdown: Connect to server socket to wake up the loop #130680

[encukou]

Currently, socketserver.serve_forever() sets a variable and serve_forever() polls for it, with a configurable interval.

A comment in the code already says:
# XXX: Consider using another file descriptor or connecting to the
# socket to wake this up instead of polling. Polling reduces our
# responsiveness to a shutdown request and wastes cpu at all other
# times.

[encukou]

This isn't a high priority for me, but I have a WIP branch in https://github.com/encukou/cpython/tree/http-server-poll
Feel free to continue it if you get to it sooner than I do.