-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-93343: Expand warning filter examples #106618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
e43adf8
f3684a6
f16ae2d
e6251be
53a8662
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -229,6 +229,39 @@ Some examples:: | |
| ignore,default:::mymodule # Only report warnings triggered by "mymodule" | ||
| error:::mymodule # Convert warnings to errors in "mymodule" | ||
|
|
||
| .. _warning-filter-examples: | ||
|
|
||
| Warning Filter Examples | ||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Here are some complex examples for filtering warnings. | ||
|
|
||
| Note that :func:`filterwarnings` filters have subtle differences | ||
| from :option:`-W` and :envvar:`PYTHONWARNINGS` regarding the *message* and *module* | ||
| parts of the filter (as described in :ref:`warning-filter`). | ||
| Mainly, 'message' and 'module' are regular expressions in the former, | ||
| but literal strings in the latter two. | ||
|
|
||
| :: | ||
|
|
||
| filterwarnings("ignore", message=".*generic", module=r"yourmodule\.submodule") | ||
| # Ignore warnings in "yourmodule.submodule" which contain "generic". | ||
| # Note that the '.' in 'message' marks any character and in 'module' it is escaped, | ||
| # in order to match a literal dot character. | ||
| filterwarnings("ignore", message="generic", module=r"yourmodule\.submodule") | ||
|
Comment on lines
250
to
252
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think those examples should be separated by a new line for clarity purposes. |
||
| # Ignore warnings in "yourmodule.submodule" which START with "generic". | ||
| filterwarnings("ignore", module="yourmodule.*") | ||
daniel-shimon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # Ignore all warnings in "yourmodule" and its submodules. | ||
| # Note that the '.' in 'module' marks any character so is not escaped. | ||
|
|
||
| -W "ignore:generic::yourmodule.submodule:" | ||
| # Ignore warnings in "yourmodule.submodule" which START with "generic" | ||
| # (but not those containing it). | ||
| # Also note that the '.' in the module part does not need to be escaped | ||
| # since it is not a regular expression. | ||
| -W "ignore:::yourmodule:" | ||
| # Ignore all warnings in "yourmodule", but NOT in its submodules. | ||
|
|
||
|
|
||
| .. _default-warning-filter: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -318,6 +318,18 @@ def test_message_matching(self): | |
| self.module.warn("something completely different") | ||
| self.assertEqual(w, []) | ||
|
|
||
| def test_message_matching_regex(self): | ||
| with original_warnings.catch_warnings(record=True, | ||
| module=self.module) as w: | ||
| self.module.simplefilter("ignore", UserWarning) | ||
| self.module.filterwarnings("error", ".*match", UserWarning) | ||
| self.assertRaises(UserWarning, self.module.warn, "match") | ||
| self.assertRaises(UserWarning, self.module.warn, "match prefix") | ||
| self.assertRaises(UserWarning, self.module.warn, "suffix match") | ||
| self.assertEqual(w, []) | ||
| self.module.warn("not a m4tch") | ||
| self.assertEqual(w, []) | ||
|
|
||
| def test_mutate_filter_list(self): | ||
| class X: | ||
| def match(self, a): | ||
|
|
@@ -1352,6 +1364,18 @@ def test_single_warning(self): | |
| PYTHONDEVMODE="") | ||
| self.assertEqual(stdout, b"['ignore::DeprecationWarning']") | ||
|
|
||
| def test_string_literals(self): | ||
| # Ensure message/module are treated as string literals | ||
| rc, stdout, stderr = assert_python_ok("-c", | ||
|
||
| "import sys, warnings; " | ||
| "sys.stdout.write(warnings.filters[0][1].pattern); " | ||
| "sys.stderr.write(warnings.filters[0][3].pattern)", | ||
| PYTHONWARNINGS="ignore:.generic::yourmodule.submodule", | ||
| PYTHONDEVMODE="") | ||
| self.assertEqual(stdout, rb"\.generic") | ||
| # '\Z' is added to the module name, so check start of pattern: | ||
| self.assertTrue(stderr.startswith(rb"yourmodule\.submodule")) | ||
|
|
||
| def test_comma_separated_warnings(self): | ||
| rc, stdout, stderr = assert_python_ok("-c", | ||
| "import sys; sys.stdout.write(str(sys.warnoptions))", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add examples of warning filters and the difference between programmatic and | ||
| environmental filters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be escaped as well? The
rhere is not necessary, and its usage should be consistent between the two args (assuming they are both regexes).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No since the first arg wants to capture strings that contain 'generic' so that the '.' catches everything, while the first arg want to capture 'yourmodule.submodule' specifically, meaning that the '.' actually captures dot and should be escaped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it sounds to me you should put that explanation into the docs, @daniel-shimon; if it is unclear for a reviewer, it is not going to be clear for the average docs reader ;)