GH-107674: Avoid allocating boxed ints for sys.settrace line events
#107780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ericsnowcurrently
approved these changes
Aug 9, 2023
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2023
…events (pythonGH-107780) (cherry picked from commit 37d8b90) Co-authored-by: Mark Shannon <[email protected]>
|
GH-107841 is a backport of this pull request to the 3.12 branch. |
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Apr 1, 2025
Summary: python/cpython#107674 slowdown in 3.12 settrace behavior this affects coverage python/cpython#127953 quadratic behavior for dictionaries. also possible python/cpython#107780 which has to do with boxing and unbox of python ints These fixes have not been merged into 3.12 trunk, for one the quadratic behavior fix doesn't patch cleanly. Enums are particularly painful because in thrift-py the .py contains two potentially large dict literals and a large class declaration. The problem was less pronounced in thrift-python because it doesn't have these large dicts and there seems to be some optimization for enums Removing just the dictionaries and leaving the class was not enough. Removing the large class was not enough. But building up the dictionaries and class at import time solves the problem. Reviewed By: itamaro Differential Revision: D72197140 fbshipit-source-id: 2c209bb12f232a0001570b77ec0e9fd28fcf4965
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Apr 1, 2025
Summary: python/cpython#107674 slowdown in 3.12 settrace behavior this affects coverage python/cpython#127953 quadratic behavior for dictionaries. also possible python/cpython#107780 which has to do with boxing and unbox of python ints These fixes have not been merged into 3.12 trunk, for one the quadratic behavior fix doesn't patch cleanly. Enums are particularly painful because in thrift-py the .py contains two potentially large dict literals and a large class declaration. The problem was less pronounced in thrift-python because it doesn't have these large dicts and there seems to be some optimization for enums Removing just the dictionaries and leaving the class was not enough. Removing the large class was not enough. But building up the dictionaries and class at import time solves the problem. Reviewed By: itamaro Differential Revision: D72197140 fbshipit-source-id: 2c209bb12f232a0001570b77ec0e9fd28fcf4965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks are noisy but show a 6% performance increase for coverage.