Add SynchronizedBase to __all__ in multiprocessing.sharedctypes
#110304
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
Reviewers: I didn't think this needed a GH Issue # b/c it's such a small change. I'm fine with exporting a different class, or masking this differently, but - to me - this seems like something that's obviously necessary. If this shouldn't go in, I'm fine with it not going in. |
Recently I was writing some heavily-parallel code, and I tried to type-check with `mypy`. I (naively) thought that `multiprocessing.Value` was a class and was very confused when `mypy` threw an error on that line. I dropped into the interpreter and tried to use the `help` function to find the return type of `Value` - and failed. I dropped into the code and found that the type returned from the `Value` function was not exported from the module. I want types in Python to be _awesome_. I think `mypy` is a step in the right direction for that. This change is me doing my part to expose more types so `mypy` can become as good as it can be. distortedsignal<[email protected]>
distortedsignal
force-pushed
the
export_SynchBase
branch
from
18ba3f0 to
b58403e
Compare
|
Boop. |
| # Methods for getting synchronization wrappers | ||
| 'Value', 'Array', | ||
| # The synchronization types | ||
| 'Synchronized', 'SynchronizedArray', 'SynchronizedString', |
There was a problem hiding this comment.
These are not documented and therefore not properly public, why should they be added to __all__?
There was a problem hiding this comment.
The original context of the code I was writing is lost, but I feel like I covered it pretty well in the PR description. This is to make it easier to type multiprocessing code.
There was a problem hiding this comment.
(By which I mean use types with… not physically type on a keyboard)
AA-Turner
changed the title
multiprocessing.sharedctypes
| @@ -0,0 +1,4 @@ | |||
| Export :class:`multiprocessing.Synchronized`, | |||
There was a problem hiding this comment.
I'm assuming this will have to be changed to a different file?
2 participants
Recently I was writing some heavily-parallel code,
and I tried to type-check with
mypy. I (naively)thought that
multiprocessing.Valuewas a classand was very confused when
mypythrew an erroron that line. I dropped into the interpreter and
tried to use the
helpfunction to find thereturn type of
Value- and failed. I droppedinto the code and found that the type returned
from the
Valuefunction was not exported fromthe module.
I want types in Python to be awesome. I think
mypyis a step in the right direction for that.This change is me doing my part to expose more
types so
mypycan become as good as it can be.