From 73f0bb500e5bc9d5f1313d66010b6596823972f0 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 31 Jan 2024 11:46:42 +0300 Subject: [PATCH 1/5] gh-114788: Do not run JIT workflow on unrelated changes --- .github/workflows/jit.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 3da72919181255..5018303cfaef47 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -1,10 +1,17 @@ name: JIT on: pull_request: - paths: '**jit**' + paths: + - '**/*jit/**' push: - paths: '**jit**' + paths: + - '**/*jit/**' workflow_dispatch: + +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + cancel-in-progress: true + jobs: jit: name: ${{ matrix.target }} (${{ matrix.debug && 'Debug' || 'Release' }}) From 38e08b8145696610066c00070da679152a168403 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 31 Jan 2024 11:50:06 +0300 Subject: [PATCH 2/5] Include files named `jit` --- .github/workflows/jit.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 5018303cfaef47..16c3c0d433ac47 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -3,9 +3,11 @@ on: pull_request: paths: - '**/*jit/**' + - '**/*jit.*' push: paths: - '**/*jit/**' + - '**/*jit.*' workflow_dispatch: concurrency: From 709def2b634fe4aa03c80e46473a6995be8c52d8 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 31 Jan 2024 11:52:55 +0300 Subject: [PATCH 3/5] Adjust globs --- .github/workflows/jit.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 16c3c0d433ac47..443bbf21e8fb3b 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -2,12 +2,12 @@ name: JIT on: pull_request: paths: - - '**/*jit/**' - - '**/*jit.*' + - '**/*jit*/**' + - '**/*jit*.*' push: paths: - '**/*jit/**' - - '**/*jit.*' + - '**/*jit*.*' workflow_dispatch: concurrency: From cd1e67fa90b6e939e39791b4d2ed1bbed087824b Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Wed, 31 Jan 2024 14:55:49 +0300 Subject: [PATCH 4/5] Apply suggestions from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> --- .github/workflows/jit.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 443bbf21e8fb3b..a38fd695ad3567 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -2,12 +2,10 @@ name: JIT on: pull_request: paths: - - '**/*jit*/**' - - '**/*jit*.*' + - '**jit**' push: paths: - - '**/*jit/**' - - '**/*jit*.*' + - '**jit**' workflow_dispatch: concurrency: From 83a5840825489ddaa44458a3c59d9f0b05c490e4 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 31 Jan 2024 20:06:32 +0300 Subject: [PATCH 5/5] Address review --- .github/workflows/jit.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index a38fd695ad3567..22e0bdba53ffd6 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -3,9 +3,11 @@ on: pull_request: paths: - '**jit**' + - 'Python/bytecodes.c' push: paths: - '**jit**' + - 'Python/bytecodes.c' workflow_dispatch: concurrency: