gh-90984: clarify math.rst preamble sentence about return types #124297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most functions in the module return floats, some might be clearly (for the reader) identified as returning integers (e.g. comb(), non-integer inputs rejected) and few (e.g. prod() and sumprod()) return something, that depends on types in the input.
skirpichev
added
needs backport to 3.12
bedevere-app
bot
added
awaiting review
docs
|
CC @rhettinger (asked for review as you were assigned on issue) |
eendebakpt
reviewed
Sep 21, 2024
eendebakpt
approved these changes
Sep 27, 2024
AA-Turner
removed
needs backport to 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most functions in the module return floats, some might be clearly (for the reader) identified as returning integers (e.g. comb(), non-integer inputs rejected) and few (e.g. prod() and sumprod()) return something, that depends on types in the input.
New preamble should cover all three cases.
📚 Documentation preview 📚: https://cpython-previews--124297.org.readthedocs.build/