Add @staticmethod where possible in venv module.
#124300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zooba can you take a look at this PR please (and apply skip issue, skip news labels if possible). |
Hey JackDuszenko. |
And, you should added issue-number in title. |
rruuaanng
reviewed
Sep 21, 2024
| self.upgrade_dependencies(context) | ||
|
|
||
| def clear_directory(self, path): | ||
| @staticmethod |
There was a problem hiding this comment.
It seems that's this @staticmethod has no substantial effect. I don't think it's necessary.
|
Thanks for your contribution, Jacek! Sorry, but CPython as a rule does not accepts a cosmetic changes, and none of these methods are documented in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernise
venvcode by adding staticmethod decorator when self is not used.