Skip to content

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Dec 6, 2024

Some hypothesis tests are failing.

This reverts commit 36c6178.

…irst_nonascii` (pythonGH-127566)"

Some hypothesis tests are failing.

This reverts commit 36c6178.
@picnixz
Copy link
Member

picnixz commented Dec 6, 2024

Actually, I checked locally and the issue already exists. Can you check the following on a released 3.12 or something like that? So maybe it's not my code that is the issue but something else and the tests were never run for some reason?

>>> import binascii
>>> x = b'\n\r\n'
>>> y = binascii.b2a_qp(x, quotetabs=False, istext=True, header=False)
>>> z = binascii.a2b_qp(y, header=False)
>>> x
b'\n\r\n'
>>> z
b'\n\n'

This is: https://github.com/python/cpython/actions/runs/12200589926/job/34037087571#step:22:214.

@colesbury colesbury marked this pull request as draft December 6, 2024 15:09
@colesbury
Copy link
Contributor Author

Yes, I think you're right. The hypothesis tests run on randomized inputs. I think we need to do a better job of running the tests for longer (on more inputs) when we add new tests.

@colesbury colesbury closed this Dec 6, 2024
@colesbury colesbury deleted the gh-126024-revert branch December 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants