- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
Docs: amend json.dump() post gh-128482 #128489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            erlend-aasland
  merged 1 commit into
  python:main
from
erlend-aasland:docs/json-dump-fixup
  
      
      
   
  Jan 4, 2025 
      
    
                
     Merged
            
            Docs: amend json.dump() post gh-128482 #128489
                    erlend-aasland
  merged 1 commit into
  python:main
from
erlend-aasland:docs/json-dump-fixup
  
      
      
   
  Jan 4, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    hugovk
  
              
              approved these changes
              
                  
                    Jan 4, 2025 
                  
              
              
            
            
      
        
              This comment was marked as outdated.
        
        
      
    
  This comment was marked as outdated.
| Thanks for the review! | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jan 4, 2025 
    
    
      
  
    
      
    
  
(cherry picked from commit 87ee760) Co-authored-by: Erlend E. Aasland <[email protected]>
| GH-128493 is a backport of this pull request to the 3.13 branch. | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jan 4, 2025 
    
    
      
  
    
      
    
  
(cherry picked from commit 87ee760) Co-authored-by: Erlend E. Aasland <[email protected]>
| GH-128494 is a backport of this pull request to the 3.12 branch. | 
    
  erlend-aasland 
      added a commit
      that referenced
      this pull request
    
      Jan 4, 2025 
    
    
      
  
    
      
    
  
(cherry picked from commit 87ee760) Co-authored-by: Erlend E. Aasland <[email protected]>
    
  erlend-aasland 
      added a commit
      that referenced
      this pull request
    
      Jan 4, 2025 
    
    
      
  
    
      
    
  
(cherry picked from commit 87ee760) Co-authored-by: Erlend E. Aasland <[email protected]>
    
  srinivasreddy 
      pushed a commit
        to srinivasreddy/cpython
      that referenced
      this pull request
    
      Jan 6, 2025 
    
    
  
    
  srinivasreddy 
      pushed a commit
        to srinivasreddy/cpython
      that referenced
      this pull request
    
      Jan 8, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
📚 Documentation preview 📚: https://cpython-previews--128489.org.readthedocs.build/