Skip to content

gh-128364: Fix flaky test_timeout test #130724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2025
Merged

gh-128364: Fix flaky test_timeout test #130724

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72783ce
gh-128364: Fix flaky `test_timeout` test
colesbury Mar 1, 2025
827bbbb
Use multiprocessing.Manager for process based executors
colesbury Mar 1, 2025
44483a0
Clean up code
colesbury Mar 1, 2025
adc7436
Update Lib/test/test_concurrent_futures/test_wait.py
colesbury Mar 1, 2025
758ca25
Remove event.clear() call
colesbury Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Lib/test/test_concurrent_futures/test_wait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ def test_all_completed(self):

def test_timeout(self):
short_timeout = 0.050
long_timeout = short_timeout * 10
event = threading.Event()

future = self.executor.submit(time.sleep, long_timeout)
future = self.executor.submit(event.wait)

finished, pending = futures.wait(
[CANCELLED_AND_NOTIFIED_FUTURE,
Expand All @@ -126,6 +126,9 @@ def test_timeout(self):
timeout=short_timeout,
return_when=futures.ALL_COMPLETED)

event.set()
futures.wait([future], return_when=futures.ALL_COMPLETED)

self.assertEqual(set([CANCELLED_AND_NOTIFIED_FUTURE,
EXCEPTION_FUTURE,
SUCCESSFUL_FUTURE]),
Expand Down
Loading