Remove special handling for mac os versions < Mac OS X 10.2 #131090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
OSX 10.2 was released in 2003, I think that it is safe to drop the support. All tests pass on recent macOS (14.5)
» ./python.exe -m test test_socket
Using random seed: 74284401
0:00:00 load avg: 2.36 Run 1 test sequentially in a single process
0:00:00 load avg: 2.36 [1/1] test_socket
/Users/sobolev/Desktop/cpython/Lib/test/test_socket.py:3044: RuntimeWarning: received malformed or improperly-truncated ancillary data
result = sock.recvmsg_into([buf], *args)
/Users/sobolev/Desktop/cpython/Lib/test/test_socket.py:2953: RuntimeWarning: received malformed or improperly-truncated ancillary data
result = sock.recvmsg(bufsize, *args)
0:00:27 load avg: 2.04 [1/1] test_socket passed
== Tests result: SUCCESS ==
1 test OK.
Total duration: 27.5 sec
Total tests: run=737 skipped=249
Total test files: run=1/1
Result: SUCCESS
Thank you!
ned-deily
approved these changes
Mar 13, 2025
|
Thanks for the PR, @maxbachmann! |
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OS X 10.1 isn't supported anymore so we can drop this special handling
I don't think this requires an issue and news entry