Skip to content

gh-131254: ensure that BROWSER is not set for test_webbrowser on macOS #131276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2025
Merged

gh-131254: ensure that BROWSER is not set for test_webbrowser on macOS #131276

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2e08aa
ensure that BROWSER is not set for `test_webbrowser` on macOS.
picnixz Mar 15, 2025
431d827
fix possible KeyError
picnixz Mar 15, 2025
a32c280
Actually, `unset` checks for the existence of the key.
picnixz Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Lib/test/test_webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,14 @@ def close(self):
@unittest.skipUnless(sys.platform == "darwin", "macOS specific test")
@requires_subprocess()
class MacOSXOSAScriptTest(unittest.TestCase):

def setUp(self):
# Ensure that 'BROWSER' is not set to 'open' or something else.
# See: https://github.com/python/cpython/issues/131254.
env = self.enterContext(os_helper.EnvironmentVarGuard())
if "BROWSER" in env:
env.unset("BROWSER")

support.patch(self, os, "popen", self.mock_popen)
self.browser = webbrowser.MacOSXOSAScript("default")

Expand Down
Loading