GH-131729: Consider in-memory state when merging storage and stack #131773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Looks good, thanks for the quick fix.
Looking at the _IS_NONE example, is there a way so that the new line is only added to the bottom of the first arm? It seems inefficient to store it twice whenever the else branch is taken (but maybe it's too difficult to avoid).
| stack_pointer = _PyFrame_GetStackPointer(frame); | ||
| } | ||
| } | ||
| stack_pointer[-1] = iter; |
There was a problem hiding this comment.
Not something to be fixed here, but worth noting that this is unnessesary (the only paths that don't store iter set iter = iterable, which leaves the stack unchanged). Could be pretty difficult for the code generator to reason about though, I don't know...
There was a problem hiding this comment.
This won't be an issue with top-of-stack caching, so I'm not concerned about it.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #131732