gh-132097: fix runtime UB when calling expat handlers #132265
Merged
+45
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also changed a bit the code style because most of the file is using
TYPE *NAMEinstead ofTYPE* NAMEdeclarations. And also, there were already inconsistencies in the affected functions. I've also changed_XMLParser_CASTintoXMLParserObject_CASTbecause it's easier to remember<NAME>_<CAST>instead of<SOMETHING_ELSE>_<CAST>(anyway it was me who introduced that macro last year but I didn't think of that at that time).Review without whitespace changes: https://github.com/python/cpython/pull/132265/files?diff=split&w=1.
-fsanitize=undefined -fno-sanitize-recover#132097