gh-133412: remove the brackets of the optional stack_effect #133708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
approved these changes
May 8, 2025
|
Thanks @nybblista for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @nybblista for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2025
The `stack_effect` is incorrectly documented as being allowed to be optional. (cherry picked from commit f77dac6) Co-authored-by: Nybblista <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2025
The `stack_effect` is incorrectly documented as being allowed to be optional. (cherry picked from commit f77dac6) Co-authored-by: Nybblista <[email protected]>
|
GH-133729 is a backport of this pull request to the 3.14 branch. |
|
GH-133730 is a backport of this pull request to the 3.13 branch. |
picnixz
pushed a commit
that referenced
this pull request
May 9, 2025
…133729) gh-133412: amend docs for the `inst` definition (GH-133708) The `stack_effect` is incorrectly documented as being allowed to be optional. (cherry picked from commit f77dac6) Co-authored-by: Nybblista <[email protected]>
picnixz
pushed a commit
that referenced
this pull request
May 9, 2025
…133730) gh-133412: amend docs for the `inst` definition (GH-133708) The `stack_effect` is incorrectly documented as being allowed to be optional. (cherry picked from commit f77dac6) Co-authored-by: Nybblista <[email protected]>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
The `stack_effect` is incorrectly documented as being allowed to be optional.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
The `stack_effect` is incorrectly documented as being allowed to be optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the brackets of the optional
stack_effect.instdefintion and its optionalstack_effect#133412