Skip to content

gh-113878: Fix versionadded in dataclasses.field() documentation #134065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2025
Merged

gh-113878: Fix versionadded in dataclasses.field() documentation #134065

merged 1 commit into from
May 17, 2025

Conversation

@Viicos
Copy link
Contributor

@Viicos Viicos commented May 15, 2025 •
edited by bedevere-app bot
Loading

@Viicos Viicos requested a review from ericvsmith as a code owner May 15, 2025 19:43
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels May 15, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 15, 2025
@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label May 15, 2025
@picnixz
Copy link
Member

picnixz commented May 15, 2025

@Viicos Can you find the issue that was used to add this feature and use it for the PR's issue number? TiA

@Viicos Viicos changed the title Fix versionadded in dataclasses.field() documentation gh-113878: Fix versionadded in dataclasses.field() documentation May 15, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 15, 2025
Closed
@picnixz picnixz self-assigned this May 15, 2025
ericvsmith
ericvsmith approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz merged commit 9d73875 into python:main May 17, 2025
43 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 17, 2025
@miss-islington-app
Copy link

Thanks @Viicos for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2025
@Viicos @miss-islington
pythongh-113878: fix versionadded in dataclasses.field() document…
d631daa 
…ation (pythonGH-134065)

(cherry picked from commit 9d73875)

Co-authored-by: Victorien <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 17, 2025

GH-134128 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 17, 2025
picnixz pushed a commit that referenced this pull request May 17, 2025
@miss-islington @Viicos
[3.14] gh-113878: fix versionadded in dataclasses.field() documen…
851b26f 
…tation (GH-134065) (#134128)

gh-113878: fix `versionadded` in `dataclasses.field()` documentation (GH-134065)
(cherry picked from commit 9d73875)

Co-authored-by: Victorien <[email protected]>
@Viicos Viicos deleted the patch-2 branch May 17, 2025 08:26
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Viicos @Pranjal095
pythongh-113878: fix versionadded in dataclasses.field() document…
a69704c 
…ation (python#134065)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Viicos @taegyunkim
pythongh-113878: fix versionadded in dataclasses.field() document…
ab1384f 
…ation (python#134065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

@picnixz picnixz picnixz approved these changes

Assignees

@picnixz picnixz

Labels

docs Documentation in the Doc dir skip news topic-dataclasses

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Viicos @picnixz @ericvsmith @ZeroIntensity