- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.3k
 
          gh-134322: fix the __repr__ value of threading.RLock from _threadmodule, when just created 
          #134389
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    vstinner
  
              
              reviewed
              
                  
                    May 20, 2025 
                  
              
              
            
            
              
                    colesbury
  
              
              reviewed
              
                  
                    May 20, 2025 
                  
              
              
            
            
              
                    vstinner
  
              
              reviewed
              
                  
                    May 21, 2025 
                  
              
              
            
            
              
                    vstinner
  
              
              approved these changes
              
                  
                    May 22, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      May 22, 2025 
    
    
      
  
    
      
    
  
Fix the `__repr__` value of `threading.RLock` from `_thread` module, when just created. (cherry picked from commit fade146) Co-authored-by: Duprat <[email protected]>
| 
           GH-134528 is a backport of this pull request to the 3.14 branch.  | 
    
    
  vstinner 
      pushed a commit
      that referenced
      this pull request
    
      May 22, 2025 
    
    
  
    
  lkollar 
      pushed a commit
        to lkollar/cpython
      that referenced
      this pull request
    
      May 26, 2025 
    
    
      
  
    
      
    
  
Fix the `__repr__` value of `threading.RLock` from `_thread` module, when just created.
    
  Pranjal095 
      pushed a commit
        to Pranjal095/cpython
      that referenced
      this pull request
    
      Jul 12, 2025 
    
    
      
  
    
      
    
  
Fix the `__repr__` value of `threading.RLock` from `_thread` module, when just created.
    
  taegyunkim 
      pushed a commit
        to taegyunkim/cpython
      that referenced
      this pull request
    
      Aug 4, 2025 
    
    
      
  
    
      
    
  
Fix the `__repr__` value of `threading.RLock` from `_thread` module, when just created.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
When a
threading.RLockis just created, the value of_countattribute is set to 1 instead of 0.Note that
__repr__is correct when_threadmodule is inactive.reprofthreading.RLockis erronous with the_threadmodule #134322