Skip to content

gh-134551: Add t-strings support to pprint #134577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-134551: Add t-strings support to pprint #134577

wants to merge 5 commits into from

Conversation

@loic-simon
Copy link
Contributor

@loic-simon loic-simon commented May 23, 2025 •
edited by bedevere-app bot
Loading

Handle formatting of Template and Interpolation types in pprint functions:

>>> from pprint import pp
>>> name = "World"
>>> pp(t"Hello {World}")
Template(strings=('Hello ', ''),
         interpolations=(Interpolation('World', 'name', None, ''),))""")

Very straightforward, using existing PrettyPrinter helper methods.

To avoid slowing import time, I did not import Template and Interpolation from string.templatelib, but instead copied their (very simple) definition:

cpython/Lib/string/templatelib.py

Lines 8 to 11 in 99a9ab1

t = t"{0}"
Template = type(t)
Interpolation = type(t.interpolations[0])
del t

@bedevere-app bedevere-app bot mentioned this pull request May 23, 2025
Open
@loic-simon
Copy link
Contributor Author

loic-simon commented May 23, 2025 •
edited
Loading

Not sure why test.test_tokenize.TestRoundtrip.test_random_files fails on test_pprint.py? If I replace t-strings by f-strings it pass, is it an issue with the test not handling t-strings? Or a real issue with tokenizer round-trippring and t-strings?

Edit: looks like a real problem, I have a MRE, opening an issue soon

@loic-simon loic-simon mentioned this pull request May 23, 2025
Closed
hugovk
hugovk reviewed May 23, 2025
View reviewed changes
@AlexWaygood AlexWaygood removed their request for review June 16, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic-simon @hugovk