Skip to content

Conversation

@aisk
Copy link
Contributor

@aisk aisk commented Jun 22, 2025

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you come up with a meaningful regression test for this?

@aisk
Copy link
Contributor Author

aisk commented Jun 26, 2025

Thank you for the review, updated!

@marcelotduarte
Copy link

@aisk This second commit will not break the patches I already have in use in cx_Freeze, because I monkeypatched freeze_support. And it does not interfere with the start method in Python (since it is not frozen). On Windows, this should work as it was before the PR that caused the regression. On Linux and macOS, I will continue monkeypatching until the gh-76327 is applied.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants