gh-135839: Fix module_traverse and module_clear in subinterp modules
#135937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
needs backport to 3.13
|
Since the change is trivial, I will set up an automerge. |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2025
…p modules (pythonGH-135937) (cherry picked from commit bcc2cba) Co-authored-by: sobolevn <[email protected]>
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
GH-135939 is a backport of this pull request to the 3.14 branch. |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Jun 25, 2025
…ubinterp modules (pythonGH-135937) (cherry picked from commit bcc2cba) Co-authored-by: sobolevn <[email protected]>
|
GH-135943 is a backport of this pull request to the 3.13 branch. |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found it after working on #135840
traverse_module_statecan returnint, do not use(void)for it #135839