Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 21, 2025

@sobolevn
Copy link
Member Author

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 69e0d6c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136939%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane
Copy link
Contributor

The change to Python/sysmodule.c looks good to me. As far as Python/emscripten_syscalls.c, I think I'd prefer to keep the code as close as possible to the reference Emscripten code which uses var.

@freakboy3742
Copy link
Contributor

Agree with @hoodmane - it makes sense to clean up the "Python internal" usage; but when there's code being synchronised with upstream, we should (to the extent possible) keep the var/let/const usage consistent.

@sobolevn sobolevn closed this Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants