- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
          gh-136437: Convert more os.path functions to pos-only in the docs
          #136970
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    AA-Turner
  
              
              approved these changes
              
                  
                    Jul 22, 2025 
                  
              
              
            
            
| Thanks @sobolevn for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jul 22, 2025 
    
    
      
  
    
      
    
  
…y in the docs (pythonGH-136970) (cherry picked from commit b31e5d6) Co-authored-by: sobolevn <[email protected]>
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jul 22, 2025 
    
    
      
  
    
      
    
  
…y in the docs (pythonGH-136970) (cherry picked from commit b31e5d6) Co-authored-by: sobolevn <[email protected]>
| GH-137000 is a backport of this pull request to the 3.14 branch. | 
| GH-137001 is a backport of this pull request to the 3.13 branch. | 
    
  AA-Turner 
      pushed a commit
      that referenced
      this pull request
    
      Jul 22, 2025 
    
    
      
  
    
      
    
  
…ly in the docs (GH-136970) (#137001) Co-authored-by: sobolevn <[email protected]>
    
  taegyunkim 
      pushed a commit
        to taegyunkim/cpython
      that referenced
      this pull request
    
      Aug 4, 2025 
    
    
      
  
    
      
    
  
…y in the docs (python#136970)
    
  hugovk 
      pushed a commit
      that referenced
      this pull request
    
      Aug 15, 2025 
    
    
      
  
    
      
    
  
…ly in the docs (GH-136970) (#137000) Co-authored-by: sobolevn <[email protected]>
    
  Agent-Hellboy 
      pushed a commit
        to Agent-Hellboy/cpython
      that referenced
      this pull request
    
      Aug 19, 2025 
    
    
      
  
    
      
    
  
…y in the docs (python#136970)
    
  kumaraditya303 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Sep 9, 2025 
    
    
      
  
    
      
    
  
…nal-only in the docs (pythonGH-136970) (python#137000) Co-authored-by: sobolevn <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Notes for reviewing:
os.path.joinhas(a, *p)real signature vs(path, *paths)documented inposixpathrealpathhas(filename, *, strict=False)real vs(path, *, strict=False)documentedcommonprefix:(m)real vs(list)documentedgetsizeandget[a,m,c]timethat have(filename)real vs(path)documentedsamestathas(s1, s2)real vs(stat1, stat2)documentedsamefilehas(f1, f2)real vs(path1, path2)documentedAny others that I've missed?
os.pathdocumentation vs. runtime #136437📚 Documentation preview 📚: https://cpython-previews--136970.org.readthedocs.build/