Skip to content

gh-89905: Correct -R option doc #137608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2025
Merged

gh-89905: Correct -R option doc #137608

merged 6 commits into from
Sep 1, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Aug 10, 2025 •
edited
Loading

I can split if it is so desired, but since both are small errors/omissions and need the same backports, I see little need.

📚 Documentation preview 📚: https://cpython-previews--137608.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Aug 10, 2025
Closed
@serhiy-storchaka
Copy link
Member

It was removed in c9f54cf.

If this is re-added, you need also to update the documentation for the PYTHONHASHSEED environment variable and move it to other section.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Aug 10, 2025 •
edited
Loading

Thanks, I'll remove it and just leave the doc fix.

I think this should be deprecated.

@StanFromIreland StanFromIreland changed the title gh-89905: Add -R option to -h and correct using/cmdline doc gh-89905: Correct -R option doc Aug 10, 2025
serhiy-storchaka
serhiy-storchaka reviewed Aug 18, 2025
View reviewed changes
@StanFromIreland StanFromIreland mentioned this pull request Aug 18, 2025
Open
@vstinner
Copy link
Member

vstinner commented Sep 1, 2025

I think this should be deprecated.

Note that it's nicer for users to keep old options forever: https://discuss.python.org/t/consider-deprecating-and-eventually-removing-b-cli-flag/96903/6

@StanFromIreland
Copy link
Member Author

Yes, I plan to have is as an undocumented NO-OP per the issue #137897

vstinner
vstinner reviewed Sep 1, 2025
View reviewed changes
vstinner
vstinner approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think @serhiy-storchaka?

@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 1, 2025
@vstinner vstinner merged commit b3ff316 into python:main Sep 1, 2025
35 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2025
@StanFromIreland @miss-islington
pythongh-89905: Correct -R option doc (pythonGH-137608)
f20f29d 
(cherry picked from commit b3ff316)

Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2025
@StanFromIreland @miss-islington
pythongh-89905: Correct -R option doc (pythonGH-137608)
8d60898 
(cherry picked from commit b3ff316)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 1, 2025

GH-138353 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 1, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 1, 2025

GH-138354 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 1, 2025
@StanFromIreland StanFromIreland deleted the r-option branch September 1, 2025 17:59
vstinner pushed a commit that referenced this pull request Sep 1, 2025
@miss-islington @StanFromIreland
[3.13] gh-89905: Correct -R option doc (GH-137608) (#138354)
406a81f 
gh-89905: Correct `-R` option doc (GH-137608)
(cherry picked from commit b3ff316)

Co-authored-by: Stan Ulbrych <[email protected]>
hugovk pushed a commit that referenced this pull request Sep 8, 2025
@miss-islington @StanFromIreland
[3.14] gh-89905: Correct -R option doc (GH-137608) (#138353)
769f7a5 
Co-authored-by: Stan Ulbrych <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @StanFromIreland @kumaraditya303
[3.14] pythongh-89905: Correct -R option doc (pythonGH-137608) (pyt…
6815364 
…hon#138353)

Co-authored-by: Stan Ulbrych <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@StanFromIreland @lkollar
pythongh-89905: Correct -R option doc (python#137608)
e972515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@benjaminp benjaminp Awaiting requested review from benjaminp

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @serhiy-storchaka @vstinner