Skip to content

gh-137808: use argument clinic for _thread.lock and _thread.RLock #137809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025
Merged

gh-137808: use argument clinic for _thread.lock and _thread.RLock #137809

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37f711b
use AC for _thread.lock and _thread.RLock
kumaraditya303 Aug 15, 2025
5258361
fix typo
kumaraditya303 Aug 15, 2025
7593145
__exit__ args are required
kumaraditya303 Aug 15, 2025
3f79167
fix format of __exit__
kumaraditya303 Aug 15, 2025
c696bee
fix _acquire_restore
kumaraditya303 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,12 +883,12 @@ Release the lock.

Allows another thread that is blocked waiting for
the lock to acquire the lock. The lock must be in the locked state,
but it needn't be locked by the same thread that unlocks it.");
but it needn't be locked by the same thread that unlocks it.
[clinic start generated code]*/

static PyObject *
_thread_lock_release_impl(lockobject *self)
/*[clinic end generated code: output=a4ab0d75d6e9fb73 input=ed3d336b9d9123f5]*/
/*[clinic end generated code: output=a4ab0d75d6e9fb73 input=dfe48f962dfe99b4]*/
{
/* Sanity check: the lock must be locked */
if (_PyMutex_TryUnlock(&self->lock) < 0) {
Expand Down Expand Up @@ -927,9 +927,9 @@ _thread_lock___enter___impl(lockobject *self)

/*[clinic input]
_thread.lock.__exit__
exc_type: object = None
exc_value: object = None
exc_tb: object = None
exc_type: object
exc_value: object
exc_tb: object
/

Release the lock.
Expand All @@ -938,7 +938,7 @@ Release the lock.
static PyObject *
_thread_lock___exit___impl(lockobject *self, PyObject *exc_type,
PyObject *exc_value, PyObject *exc_tb)
/*[clinic end generated code: output=c9e8eefa69beed07 input=ff605bf967310447]*/
/*[clinic end generated code: output=c9e8eefa69beed07 input=f1f539437b055547]*/
{
return _thread_lock_release_impl(self);
}
Expand Down Expand Up @@ -1171,9 +1171,9 @@ _thread_RLock_release_impl(rlockobject *self)

/*[clinic input]
_thread.RLock.__exit__
exc_type: object = None
exc_value: object = None
exc_tb: object = None
exc_type: object
exc_value: object
exc_tb: object
/

Release the lock.
Expand All @@ -1183,7 +1183,7 @@ Release the lock.
static PyObject *
_thread_RLock___exit___impl(rlockobject *self, PyObject *exc_type,
PyObject *exc_value, PyObject *exc_tb)
/*[clinic end generated code: output=79bb44d551aedeb5 input=99d5cb8c7cef3077]*/
/*[clinic end generated code: output=79bb44d551aedeb5 input=79accf0778d91002]*/
{
return _thread_RLock_release_impl(self);
}
Expand Down
44 changes: 12 additions & 32 deletions Modules/clinic/_threadmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading