gh-138402: Update documentation for LOAD_ATTR and LOAD_GLOBAL #138631
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
|
@StanFromIreland I think this is getting lost completely because no one got auto assigned? Is there something i should do to get this reviewed or just wait? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically that the null is now pushed after the object since 3.13.
The issue has as a recommended solution to use the exact wording of the original changes from 3.11/3.12 but with the "before" replaced with an after. That didnt seem fully aligned to me with how the other change notices look. Especially since i never saw any that had somethingin bold/highlighted which i think would have made it clear what the difference between the changes in 3.13 vs before are. But i can obviously change it to that wording if request.
📚 Documentation preview 📚: https://cpython-previews--138631.org.readthedocs.build/