Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 15, 2025

Replace PyBytes_FromStringAndSize(NULL, size) with the new public PyBytesWriter API.

Replace PyBytes_FromStringAndSize(NULL, size) with the new public
PyBytesWriter API.
@vstinner
Copy link
Member Author

cc @picnixz

@picnixz
Copy link
Member

picnixz commented Sep 15, 2025

Note that I kept compact code toook similar to hexdigest(). So I would prefer keeping the same blank lines.

@vstinner
Copy link
Member Author

Note that I kept compact code toook similar to hexdigest(). So I would prefer keeping the same blank lines.

I changed _sha3_shake_128_hexdigest_impl() to use the same blank lines. Do you like it? Or do you prefer that I revert blank lines to the current code?

@vstinner vstinner merged commit f62b495 into python:main Sep 15, 2025
43 checks passed
@vstinner vstinner deleted the pybyteswriter_sha3 branch September 15, 2025 20:53
@vstinner
Copy link
Member Author

Merged, thanks for the review @picnixz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants