From d0586107fe0b0447c7e7fbf746f36147eb1d0d2c Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Thu, 18 Sep 2025 11:24:35 +0100 Subject: [PATCH 1/2] gh-138970: Adjust tests for pegen rule flags --- Lib/test/test_peg_generator/test_pegen.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/Lib/test/test_peg_generator/test_pegen.py b/Lib/test/test_peg_generator/test_pegen.py index 0387b9395611b0..cdb62e4e87f70e 100644 --- a/Lib/test/test_peg_generator/test_pegen.py +++ b/Lib/test/test_peg_generator/test_pegen.py @@ -1131,24 +1131,28 @@ def test_rule_flags(self) -> None: # Test memo-only rule simple_rule = rules['simple_rule'] - self.assertTrue(simple_rule.memo, "simple_rule should have memo=True") + self.assertTrue('memo' in simple_rule.flags, + "simple_rule should have memo") self.assertEqual(simple_rule.flags, frozenset(['memo']), f"simple_rule flags should be {'memo'}, got {simple_rule.flags}") # Test multi-flag rule multi_flag_rule = rules['multi_flag_rule'] - self.assertTrue(multi_flag_rule.memo, "multi_flag_rule should have memo=True") + self.assertTrue('memo' in simple_rule.flags, + "multi_flag_rule should have memo=True") self.assertEqual(multi_flag_rule.flags, frozenset({'memo', 'custom', 'test'}), f"multi_flag_rule flags should contain memo, custom, test, got {multi_flag_rule.flags}") # Test single custom flag rule single_custom_rule = rules['single_custom_flag'] - self.assertFalse(single_custom_rule.memo, "single_custom_flag should have memo=False") + self.assertFalse('memo' not in simple_rule.flags, + "single_custom_flag should not have memo") self.assertEqual(single_custom_rule.flags, frozenset(['custom']), f"single_custom_flag flags should be {'custom'}, got {single_custom_rule.flags}") # Test no flags rule no_flags_rule = rules['no_flags_rule'] - self.assertFalse(no_flags_rule.memo, "no_flags_rule should have memo=False") - self.assertEqual(no_flags_rule.flags, [], + self.assertFalse('memo' not in simple_rule.flags, + "no_flags_rule should have memo=False") + self.assertEqual(no_flags_rule.flags, frozenset(), f"no_flags_rule flags should be the empty set, got {no_flags_rule.flags}") From 28117ebf89a11a807a48ac7038d768b243ded52b Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Thu, 18 Sep 2025 11:38:33 +0100 Subject: [PATCH 2/2] Adjust wording --- Lib/test/test_peg_generator/test_pegen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_peg_generator/test_pegen.py b/Lib/test/test_peg_generator/test_pegen.py index cdb62e4e87f70e..d03ba07975a616 100644 --- a/Lib/test/test_peg_generator/test_pegen.py +++ b/Lib/test/test_peg_generator/test_pegen.py @@ -1139,7 +1139,7 @@ def test_rule_flags(self) -> None: # Test multi-flag rule multi_flag_rule = rules['multi_flag_rule'] self.assertTrue('memo' in simple_rule.flags, - "multi_flag_rule should have memo=True") + "multi_flag_rule should have memo") self.assertEqual(multi_flag_rule.flags, frozenset({'memo', 'custom', 'test'}), f"multi_flag_rule flags should contain memo, custom, test, got {multi_flag_rule.flags}") @@ -1153,6 +1153,6 @@ def test_rule_flags(self) -> None: # Test no flags rule no_flags_rule = rules['no_flags_rule'] self.assertFalse('memo' not in simple_rule.flags, - "no_flags_rule should have memo=False") + "no_flags_rule should not have memo") self.assertEqual(no_flags_rule.flags, frozenset(), f"no_flags_rule flags should be the empty set, got {no_flags_rule.flags}")