-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-116146: Add C-API to create module from spec and initfunc #139196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itamaro
wants to merge
15
commits into
python:main
Choose a base branch
from
itamaro:gh-116146-create-builtin-initfunc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+223
−21
Open
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
403c7e2
gh-116146: Add new C-API to create builtin from spec and initfunc
itamaro 074a510
Apply review feedback and CAPI WG decision
itamaro d38c0e4
Add tests for the PyImport_CreateModuleFromInitfunc API
itamaro d5be6e5
Document the new `PyImport_CreateModuleFromInitfunc` C-API
itamaro 781a730
Add news entry
itamaro 7af34eb
Fix lint
itamaro 35e9e78
fix CI
itamaro 6aa2fb2
Apply Kumar's review suggestion
itamaro f652399
PyImport_CreateModuleFromInitfunc: Doc & test update (#27)
encukou c4f1cc8
Apply Victor's review suggestions
itamaro 29b1b68
Set error if initfunc is NULL
itamaro 1165950
Account for the RuntimeWarning when import a singlephase init extensi…
itamaro 79e5d0e
Apply suggestions from code review
itamaro fbfde0a
Mention new C-API in whatsnew
itamaro f485fcb
Merge branch 'main' into gh-116146-create-builtin-initfunc
itamaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/C_API/2025-11-08-10-51-50.gh-issue-116146.pCmx6L.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add a new :c:func:`PyImport_CreateModuleFromInitfunc` C-API for creating a | ||
| module from a **spec** and **initfunc**. Patch by Itamar Oren. | ||
itamaro marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.