gh-139156: Use PyBytesWriter in PyUnicode_AsRawUnicodeEscapeString() #139250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing() Replace PyBytes_FromStringAndSize() and _PyBytes_Resize() with the PyBytesWriter API.
|
Benchmark: import pyperf
runner = pyperf.Runner()
sizes = (3, 100, 1000)
for size in sizes:
runner.timeit(f'{size:,} ASCII chars',
setup=f's="x"*{size}',
stmt='s.encode("raw_unicode_escape")')
for size in sizes:
runner.timeit(f'{size:,} UCS-2 chars',
setup=f's=chr(0x20ac) * {size}',
stmt='s.encode("raw_unicode_escape")')
for size in sizes:
runner.timeit(f'{size:,} UCS-4 chars',
setup=f's=chr(0x10ffff) * {size}',
stmt='s.encode("raw_unicode_escape")')Results:
Benchmark hidden because not significant (3): 3 ASCII chars, 100 ASCII chars, 1,000 ASCII chars The code path for U+0000-U+00FF characters is unchanged, so it's normal that the benchmark is not significant on ASCII characters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace PyBytes_FromStringAndSize() and _PyBytes_Resize() with the PyBytesWriter API.