Skip to content

gh-138489: Add missing build-details.json step for building wasm #139302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2025
Merged

gh-138489: Add missing build-details.json step for building wasm #139302

merged 3 commits into from
Oct 4, 2025

Conversation

@HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Sep 24, 2025 •
edited by picnixz
Loading

Hello, this PR just adds a missing build-details.json build step on WASM ecosystems (e.g. WASI).

When cross-compiling for WASI by build_wasm or build_emscripten, the build-details.json step is now included in the build process, just like with native builds.

This fixes the libinstall task which requires the build-details.json file during the process.

@bedevere-app
Copy link

bedevere-app bot commented Sep 24, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 24, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@HoKim98 HoKim98 changed the title Add missing build-details.json step for building wasm gh-139302: Add missing build-details.json step for building wasm Sep 24, 2025
@picnixz picnixz changed the title gh-139302: Add missing build-details.json step for building wasm gh-138489: Add missing build-details.json step for building wasm Sep 24, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 24, 2025
Open
@HoKim98 HoKim98 marked this pull request as ready for review September 24, 2025 14:03
@AA-Turner AA-Turner requested review from FFY00 and Copilot September 24, 2025 14:10
@AA-Turner
Copy link
Member

Sorry, it's far too easy to click the 'copilot' button, this was absolutely not my intent!

A

@python python deleted a comment from Copilot AI Sep 24, 2025
AA-Turner
AA-Turner reviewed Sep 24, 2025
View reviewed changes
@HoKim98 @AA-Turner
Update Makefile.pre.in
6bbad6d 
Co-authored-by: Adam Turner <[email protected]>
@HoKim98 HoKim98 force-pushed the fix/wasm-build-details.json branch from f9a947b to 6bbad6d Compare September 24, 2025 14:14

This comment was marked as spam.

Sign in to view

@emmatyping
Copy link
Member

Confirmed locally this also fixes #137878

$ wasmtime --dir /opt/wasi-python/ /opt/wasi-python/bin/python3.wasm
Python 3.15.0a0 (heads/fix/wasm-build-details.json-dirty:6bbad6d6cc2, Sep 24 2025, 10:33:33) [Clang 19.1.5-wasi-sdk (https://github.com/llvm/llvm-project ab4b5a2db582958af1e on wasi
Type "help", "copyright", "credits" or "license" for more information.
warning: can't use pyrepl: No module named 'termios'
>>> import math
>>> math.pi
3.141592653589793

emmatyping
emmatyping approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me.

FFY00
FFY00 approved these changes Oct 4, 2025
View reviewed changes
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HoKim98 😊

@FFY00 FFY00 merged commit db53ca3 into python:main Oct 4, 2025
45 checks passed
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label Oct 4, 2025
@miss-islington-app
Copy link

Thanks @HoKim98 for the PR, and @FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2025
@HoKim98 @AA-Turner @miss-islington
pythongh-138489: Add missing build-details.json step for building w…
ff0c6ac 
…asm (pythonGH-139302)

* fix: add missing `build-details.json` step for building wasm

Signed-off-by: Ho Kim <[email protected]>

* pythongh-138489: Add missing build-details.json step for building wasm

Signed-off-by: Ho Kim <[email protected]>

* Update Makefile.pre.in

Co-authored-by: Adam Turner <[email protected]>

---------
(cherry picked from commit db53ca3)

Co-authored-by: Ho Kim <[email protected]>
Signed-off-by: Ho Kim <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 4, 2025

GH-139557 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 4, 2025
@AA-Turner
Copy link
Member

I think it's worth backporting this, but it's not critical that this goes into 3.14.0. What do we think?

A

@FFY00 FFY00 added the needs backport to 3.14 bugs and security fixes label Oct 4, 2025
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2025
@HoKim98 @AA-Turner @miss-islington
pythongh-138489: Add missing build-details.json step for building w…
8cbc4bb 
…asm (pythonGH-139302)

* fix: add missing `build-details.json` step for building wasm

Signed-off-by: Ho Kim <[email protected]>

* pythongh-138489: Add missing build-details.json step for building wasm

Signed-off-by: Ho Kim <[email protected]>

* Update Makefile.pre.in

Co-authored-by: Adam Turner <[email protected]>

---------
(cherry picked from commit db53ca3)

Co-authored-by: Ho Kim <[email protected]>
Signed-off-by: Ho Kim <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@AA-Turner
Copy link
Member

Backport PR already created at GH-139557, miss-islington doesn't appear to recognise this.

A

danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@HoKim98 @AA-Turner @danigm
pythongh-138489: Add missing build-details.json step for building w…
9c81b64 
…asm (python#139302)

* fix: add missing `build-details.json` step for building wasm

Signed-off-by: Ho Kim <[email protected]>

* pythongh-138489: Add missing build-details.json step for building wasm

Signed-off-by: Ho Kim <[email protected]>

* Update Makefile.pre.in

Co-authored-by: Adam Turner <[email protected]>

---------

Signed-off-by: Ho Kim <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @HoKim98 @AA-Turner
[3.14] gh-138489: Add missing build-details.json step for building …
77b4ed2 
…wasm (GH-139302) (GH-139557)

(cherry picked from commit db53ca3)

Signed-off-by: Ho Kim <[email protected]>
Co-authored-by: Ho Kim <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

Copilot code review Copilot Copilot left review comments

@emmatyping emmatyping emmatyping approved these changes

@FFY00 FFY00 FFY00 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

@FFY00 FFY00

Labels

needs backport to 3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HoKim98 @AA-Turner @emmatyping @FFY00