Skip to content

gh-138489: Add missing build-details.json step for building wasm #139302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2025
+7 −1
Merged

gh-138489: Add missing build-details.json step for building wasm #139302

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
053a8c2
fix: add missing `build-details.json` step for building wasm
HoKim98 Sep 24, 2025
4c3bcf2
gh-138489: Add missing build-details.json step for building wasm
HoKim98 Sep 24, 2025
6bbad6d
Update Makefile.pre.in
HoKim98 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,10 +801,10 @@ build_all: check-clean-src check-app-store-compliance $(BUILDPYTHON) platform sh

.PHONY: build_wasm
build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \
python-config checksharedmods
python-config checksharedmods build-details.json

.PHONY: build_emscripten
build_emscripten: build_wasm web_example web_example_pyrepl_jspi
build_emscripten: build_wasm build-details.json web_example web_example_pyrepl_jspi

# Check that the source is clean when building out of source.
.PHONY: check-clean-src
Expand Down
6 changes: 6 additions & 0 deletions Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
When cross-compiling for WASI by ``build_wasm`` or ``build_emscripten``, the
``build-details.json`` step is now included in the build process, just like
with native builds.

This fixes the ``libinstall`` task which requires the ``build-details.json``
file during the process.
Loading