gh-90949: expose Expat API to tune exponential expansion protections #139368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
suggested changes
Sep 26, 2025
Misc/NEWS.d/next/Library/2025-09-26-18-04-28.gh-issue-90949.YHjSzX.rst
Outdated
Show resolved
Hide resolved
picnixz
commented
Sep 26, 2025
gpshead
reviewed
Sep 27, 2025
picnixz
changed the title
hartwork
approved these changes
Sep 27, 2025
There was a problem hiding this comment.
@picnixz I like this new version! 👍
One question: There were changes in here to the previous related news file. This is what it reads on main today:
# cat Misc/NEWS.d/next/Library/2025-09-22-14-40-11.gh-issue-90949.UM35nb.rst
Add :meth:`~xml.parsers.expat.xmlparser.SetAllocTrackerActivationThreshold`
and :meth:`~xml.parsers.expat.xmlparser.SetAllocTrackerMaximumAmplification`
to :ref:`xmlparser <xmlparser-objects>` objects to prevent use of
disproportional amounts of dynamic memory from within an Expat parser.
Patch by Bénédikt Tran.From what we discussed here, this should probably says things about tuning also?
Should you or me create a follow-up pull request to adjust that after this?
|
I'll amend the NEWS as part of this PR. |
gpshead
approved these changes
Sep 27, 2025
picnixz
changed the title
|
Since this is built on top of many other PRs, I'll just wait for the others to be backported first. |
This was referenced Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #139366.
cc @hartwork
📚 Documentation preview 📚: https://cpython-previews--139368.org.readthedocs.build/