[3.13] gh-139283: correctly handle size limit in cursor.fetchmany() (GH-139296)
#139444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2025
picnixz
force-pushed
the
backport-bc172ee-3.13
branch
2 times, most recently
from
2d89809 to
beaff4c
Compare
picnixz
requested review from
berkerpeksag and
erlend-aasland
as code owners
|
I'm asking for a review because we don't have the |
picnixz
changed the title
size limit in cursor.fetchmany(…) (GH-139296)size limit in cursor.fetchmany(...) (GH-139296)
picnixz
changed the title
size limit in cursor.fetchmany(...) (GH-139296)size limit in cursor.fetchmany() (GH-139296)
|
Oh. So conversion to negative value causes an OverflowError... and not a ValueError on 3.13. What to do. Should I prefer matching the exception type as I'm anyway manually converting or should I not? EDIT: Considering the |
picnixz
force-pushed
the
backport-bc172ee-3.13
branch
from
beaff4c to
83c3917
Compare
…hmany()` (pythonGH-139296) Passing a negative or zero size to `cursor.fetchmany()` made it fetch all rows instead of none. While this could be considered a security vulnerability, it was decided to treat this issue as a regular bug as passing a non-sanitized *size* value in the first place is not recommended. (cherry picked from commit bc172ee) Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
force-pushed
the
backport-bc172ee-3.13
branch
from
83c3917 to
d9c2a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a negative or zero size to
cursor.fetchmany()made it fetch all rows instead of none.While this could be considered a security vulnerability, it was decided to treat this issue as a regular bug as passing a non-sanitized size value in the first place is not recommended.
(cherry picked from commit bc172ee)
📚 Documentation preview 📚: https://cpython-previews--139444.org.readthedocs.build/