Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Lib/test/test_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -4722,6 +4722,21 @@ class D(Generic[T]): pass
with self.assertRaises(TypeError):
D[()]

def test_generic_init_subclass_not_called_error(self):
class Base:
def __init_subclass__(cls) -> None:
# Oops, I forgot super().__init_subclass__()!
pass

class Sub(Base, Generic[T]):
pass

with self.assertRaisesRegex(TypeError,
r"type object '.*Sub' has no attribute "
r"'__parameters__'; Maybe you forgot to call "
r"super\(\).__init_subclass__\(\)\?"):
Sub[int]

def test_generic_subclass_checks(self):
for typ in [list[int], List[int],
tuple[int, str], Tuple[int, str],
Expand Down
10 changes: 8 additions & 2 deletions Lib/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1158,14 +1158,20 @@ def _generic_class_getitem(cls, args):
f"Parameters to {cls.__name__}[...] must all be unique")
else:
# Subscripting a regular Generic subclass.
for param in cls.__parameters__:
try:
parameters = cls.__parameters__
except AttributeError:
raise TypeError(f"type object '{cls.__qualname__}' has no attribute "
f"'__parameters__'; Maybe you forgot to call "
f"super().__init_subclass__()?") from None
for param in parameters:
prepare = getattr(param, '__typing_prepare_subst__', None)
if prepare is not None:
args = prepare(cls, args)
_check_generic_specialization(cls, args)

new_args = []
for param, new_arg in zip(cls.__parameters__, args):
for param, new_arg in zip(parameters, args):
if isinstance(param, TypeVarTuple):
new_args.extend(new_arg)
else:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add suggestion to inscrutable error about ``cls.__parameters__`` not
existing, because ``super().__init_subclass__()`` was not called.
Loading