gh-84027: Add whl as an unpack format in shutil #140385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wheels are the most ubiquitous Python package format. Per [the wheel format specification](https://packaging.python.org/en/latest/specifications/binary-distribution-format/), "A wheel is a ZIP-format archive with a specially formatted file name and the .whl extension." To enable unpacking of wheels for inspection or even installation, we register the format in shutil using shutil._unpack_zipfile to do the actual unpacking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheels are the most ubiquitous Python package format. Per the wheel format specification, "A wheel is a ZIP-format archive with a specially formatted file name and the .whl extension."
To enable unpacking of wheels for inspection or even installation, we register the format in shutil using shutil._unpack_zipfile to do the actual unpacking.
Also, I would say we should only do this with wheels because they are Python packages. I don't want to set the precedent that we register all zip based formats :)