Skip to content

bpo-33257: Fix race conditions for non-threaded Tcl #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

bpo-33257: Fix race conditions for non-threaded Tcl #6444

wants to merge 17 commits into from

Conversation

@native-api
Copy link
Contributor

@native-api native-api commented Apr 10, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka self-requested a review April 11, 2018 07:27
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Apr 11, 2018
@native-api native-api force-pushed the tcltk_race_master branch 2 times, most recently from 3b1402d to efa3bc6 Compare April 13, 2018 17:54
@native-api native-api force-pushed the tcltk_race_master branch from ab9865d to d5e1608 Compare May 12, 2018 01:26
@native-api native-api force-pushed the tcltk_race_master branch from d5e1608 to a8833d3 Compare May 17, 2018 11:56
@native-api native-api changed the title bpo-33257: Fix race conditions for non-threaded Tcl when passing data to/from it bpo-33257: Fix race conditions for non-threaded Tcl May 17, 2018
@native-api native-api force-pushed the tcltk_race_master branch from a8833d3 to 3ee8e77 Compare May 17, 2018 12:00
@native-api
Copy link
Contributor Author

native-api commented May 17, 2018 •
edited
Loading

Comments on decisions:

  • Placed reentrant lock logic directly into Tkinter 'cuz reentrant locks aren't used anywhere else, and this is easier than overhauling all 4 PyThread lock implementations. (They're also based on condition variables which don't support reentrance.)
  • Pushed both fixes to the same PR 'cuz the test case based on TkinterHanders3.py detects both bugs and would fail CI otherwise
  • Reentry count overflow check can probably be replaced by an assert: unless there's a bug, we'll sooner hit RecursionError or MemoryError.

Test case has code nonportable to Py2. Shall I make it portable or compose a backport by hand?

@native-api native-api force-pushed the tcltk_race_master branch from 3ee8e77 to 534c57d Compare May 17, 2018 12:40
@native-api
Copy link
Contributor Author

native-api commented May 17, 2018 •
edited
Loading

Test failures on MacOS in acyncio are caused by https://bugs.python.org/issue33531 .

@bedevere-bot
Copy link

GH-6972 is a backport of this pull request to the 2.7 branch.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@native-api native-api mannequin mentioned this pull request Apr 10, 2022
Open
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 16, 2022
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label May 7, 2025
@vstinner
Copy link
Member

vstinner commented May 7, 2025

PR inactive since 2018, I close it.

@vstinner vstinner closed this May 7, 2025
@native-api
Copy link
Contributor Author

Updated the PR branch but that doesn't show here for some reason.

To test with nonthreaded Tcl, apply the attached patch, then run PCBuild/prepare_tcltk.bat, then build and test.
tcltk_nothreads.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time. type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@native-api @bedevere-bot @vstinner @serhiy-storchaka @ned-deily @the-knights-who-say-ni @ezio-melotti