Skip to content

Commit 505395a

Browse files
committed
🧎‍♀️ Genuflect to the types.
1 parent cb7e8fc commit 505395a

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

tests/fixtures.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import contextlib
88

99
from .py39compat import FS_NONASCII
10+
from typing import Dict, Union
1011

1112

1213
@contextlib.contextmanager
@@ -71,8 +72,13 @@ def setUp(self):
7172
self.fixtures.enter_context(self.add_sys_path(self.site_dir))
7273

7374

75+
# Except for python/mypy#731, prefer to define
76+
# FilesDef = Dict[str, Union['FilesDef', str]]
77+
FilesDef = Dict[str, Union[Dict[str, Union[Dict[str, str], str]], str]]
78+
79+
7480
class DistInfoPkg(OnSysPath, SiteDir):
75-
files = {
81+
files: FilesDef = {
7682
"distinfo_pkg-1.0.0.dist-info": {
7783
"METADATA": """
7884
Name: distinfo-pkg
@@ -106,7 +112,7 @@ def setUp(self):
106112

107113

108114
class EggInfoPkg(OnSysPath, SiteDir):
109-
files = {
115+
files: FilesDef = {
110116
"egginfo_pkg.egg-info": {
111117
"PKG-INFO": """
112118
Name: egginfo-pkg
@@ -143,7 +149,7 @@ def setUp(self):
143149

144150

145151
class EggInfoFile(OnSysPath, SiteDir):
146-
files = {
152+
files: FilesDef = {
147153
"egginfo_file.egg-info": """
148154
Metadata-Version: 1.0
149155
Name: egginfo_file
@@ -164,7 +170,7 @@ def setUp(self):
164170

165171

166172
class LocalPackage:
167-
files = {
173+
files: FilesDef = {
168174
"setup.py": """
169175
import setuptools
170176
setuptools.setup(name="local-pkg", version="2.0.1")

tests/test_zip.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
getattr(resources, 'files')
1818
getattr(resources, 'as_file')
1919
except (ImportError, AttributeError):
20-
import importlib_resources as resources
20+
import importlib_resources as resources # type: ignore
2121

2222

2323
class TestZip(unittest.TestCase):

0 commit comments

Comments
 (0)