Skip to content

Commit 7968a08

Browse files
committed
Expand test to include importable names that aren't identifiers and honor that expectation.
1 parent a4e2a9b commit 7968a08

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

importlib_metadata/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,7 @@ def _top_level_inferred(dist):
904904
}
905905

906906
@pass_none
907-
def valid_module(name):
908-
return name.isidentifier()
907+
def importable_name(name):
908+
return '.' not in name
909909

910-
return filter(valid_module, opt_names)
910+
return filter(importable_name, opt_names)

tests/test_main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ def test_packages_distributions_all_module_types(self):
336336
Version: 1.0.0
337337
""",
338338
'RECORD': ''.join(
339-
f'top_level_{i}{suffix},,\n'
339+
f'importable-name {i}{suffix},,\n'
340340
f'in_namespace_{i}/mod{suffix},,\n'
341341
f'in_package_{i}/__init__.py,,\n'
342342
f'in_package_{i}/mod{suffix},,\n'
@@ -350,7 +350,7 @@ def test_packages_distributions_all_module_types(self):
350350
distributions = packages_distributions()
351351

352352
for i in range(len(suffixes)):
353-
assert distributions[f'top_level_{i}'] == ['all_distributions']
353+
assert distributions[f'importable-name {i}'] == ['all_distributions']
354354
assert distributions[f'in_namespace_{i}'] == ['all_distributions']
355355
assert distributions[f'in_package_{i}'] == ['all_distributions']
356356

0 commit comments

Comments
 (0)