Skip to content

Commit 168b4b8

Browse files
committed
Address review
1 parent 5a0f305 commit 168b4b8

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

test-data/unit/check-custom-plugin.test

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,3 +1098,15 @@ reveal_type(1) # N: Revealed type is "Literal[1]?"
10981098
[file mypy.ini]
10991099
\[mypy]
11001100
plugins=<ROOT>/test-data/unit/plugins/custom_errorcode.py
1101+
1102+
1103+
[case testPyprojectPluginsTrailingComma]
1104+
# flags: --config-file tmp/pyproject.toml
1105+
[file pyproject.toml]
1106+
# This test checks that trailing commas in string-based `plugins` are allowed.
1107+
\[tool.mypy]
1108+
plugins = """
1109+
<ROOT>/test-data/unit/plugins/function_sig_hook.py,
1110+
<ROOT>/test-data/unit/plugins/method_in_decorator.py,
1111+
"""
1112+
[out]

test-data/unit/cmdline.pyproject.test

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -151,17 +151,6 @@ y: int = 'y' # E: Incompatible types in assignment (expression has type "str",
151151
z: int = 'z'
152152
[out]
153153

154-
[case testPyprojectPluginsTrailingComma-posix]
155-
# cmd: mypy .
156-
[file pyproject.toml]
157-
# This test fails on windows for some reason, skipping it there.
158-
\[tool.mypy]
159-
plugins = """
160-
<ROOT>/test-data/unit/plugins/function_sig_hook.py,
161-
<ROOT>/test-data/unit/plugins/method_in_decorator.py,
162-
"""
163-
[out]
164-
165154
[case testPyprojectAlwaysTrueTrailingComma]
166155
# cmd: mypy .
167156
[file pyproject.toml]

0 commit comments

Comments
 (0)