new idea

Author: BobTheBuidler

mypyc/codegen/emitmodule.py

@@ -990,22 +990,6 @@ def emit_module_exec_func(
                 emitter.emit_lines(f"if (unlikely(!{type_struct}))", "    goto fail;")
 
         emitter.emit_lines("if (CPyGlobalsInit() < 0)", "    goto fail;")
-        # Patch async native functions so they're recognized as coroutines
-        for fn in module.functions:
-            if fn.decl.is_async and fn.class_name is None:
-                temp_name = f"{fn.fullname.replace('.', '__')}_temp"
-                emitter.emit_line(
-                    f'PyObject *{temp_name} = PyObject_GetAttrString({module_static}, "{fn.decl.name}");'
-                )
-                emitter.emit_line(f"if (!{temp_name}) goto fail;")
-                emitter.emit_line(
-                    "if (!CPyFunc_SetCoroFlag("
-                    + temp_name
-                    + ")) { Py_DECREF("
-                    + temp_name
-                    + "); goto fail; }"
-                )
-                emitter.emit_line(f"Py_DECREF({temp_name});")
 
         self.generate_top_level_call(module, emitter)
 

mypyc/lib-rt/pythonsupport.c

@@ -103,20 +103,4 @@ CPyLong_AsSsize_tAndOverflow_(PyObject *vv, int *overflow)
 }
 
 
-// CPy support for async functions: patch code object to include CO_COROUTINE
-PyObject* CPyFunc_SetCoroFlag(PyObject* func) {
-    PyObject* code = PyObject_GetAttrString(func, "__code__");
-    if (!code) {
-        return NULL;
-    }
-    PyCodeObject* codeobj = (PyCodeObject*)code;
-    codeobj->co_flags |= CO_COROUTINE;
-    int res = PyObject_SetAttrString(func, "__code__", code);
-    Py_DECREF(code);
-    if (res < 0) {
-        return NULL;
-    }
-    Py_INCREF(func);
-    return func;
-}
 #endif

mypyc/lib-rt/pythonsupport.h

@@ -474,8 +474,5 @@ CPyCoro_GetAwaitableIter(PyObject *o)
     return NULL;
 }
 
-static PyObject *
-CPyFunc_SetCoroFlag(PyObject* func);
-
 
 #endif