Mark as experimental

Author: JukkaL

mypyc/lib-rt/librt_strings.c

@@ -280,6 +280,8 @@ static PyMethodDef librt_strings_module_methods[] = {
     {NULL, NULL, 0, NULL}
 };
 
+#ifdef MYPYC_EXPERIMENTAL
+
 static int
 strings_abi_version(void) {
     return LIBRT_STRINGS_ABI_VERSION;
@@ -290,9 +292,12 @@ strings_api_version(void) {
     return LIBRT_STRINGS_API_VERSION;
 }
 
+#endif
+
 static int
 librt_strings_module_exec(PyObject *m)
 {
+#ifdef MYPYC_EXPERIMENTAL
     if (PyType_Ready(&BytesWriterType) < 0) {
         return -1;
     }
@@ -314,6 +319,7 @@ librt_strings_module_exec(PyObject *m)
     if (PyModule_Add(m, "_C_API", c_api_object) < 0) {
         return -1;
     }
+#endif
     return 0;
 }
 

mypyc/lib-rt/librt_strings.h

@@ -1,6 +1,17 @@
 #ifndef LIBRT_STRINGS_H
 #define LIBRT_STRINGS_H
 
+#ifndef MYPYC_EXPERIMENTAL
+
+static int
+import_librt_strings(void)
+{
+    // All librt.base64 features are experimental for now, so don't set up the API here
+    return 0;
+}
+
+#else  // MYPYC_EXPERIMENTAL
+
 // ABI version -- only an exact match is compatible. This will only be changed in
 // very exceptional cases (likely never) due to strict backward compatibility
 // requirements.
@@ -62,4 +73,6 @@ static inline bool CPyBytesWriter_Check(PyObject *obj) {
     return Py_TYPE(obj) == LibRTStrings_BytesWriter_type_internal();
 }
 
+#endif  // MYPYC_EXPERIMENTAL
+
 #endif  // LIBRT_STRINGS_H

mypyc/test-data/run-librt-strings.test

@@ -86,3 +86,10 @@ def test_bytes_writer_wrapper_functions() -> None:
 
     with assertRaises(TypeError):
         b.append(-1)
+
+[case testStringsFeaturesNotAvailableInNonExperimentalBuild_librt]
+# This also ensures librt.strings can be built without experimental features
+import librt.strings
+
+def test_bytes_writer_not_available() -> None:
+    assert not hasattr(librt.strings, "BytesWriter")