Only note if the replacement is also a Decorator

sterliakov · sterliakov · commit 5f9e15a9f327 · 2025-01-28T20:37:58.000+01:00
diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -7157,7 +7157,7 @@ def already_defined(
         self.fail(
             f'{noun} "{unmangle(name)}" already defined{extra_msg}', ctx, code=codes.NO_REDEF
         )
-        if isinstance(node, Decorator) and node.func.is_property:
+        if isinstance(ctx, Decorator) and isinstance(node, Decorator) and node.func.is_property:
             self.note("Property setter and deleter must be adjacent to the getter.", ctx)
 
     def name_already_defined(

Original file line number	Diff line number	Diff line change
`@@ -7157,7 +7157,7 @@ def already_defined(`
`7157`	`7157`	`self.fail(`
`7158`	`7158`	`f'{noun} "{unmangle(name)}" already defined{extra_msg}', ctx, code=codes.NO_REDEF`
`7159`	`7159`	`)`
`7160`		`- if isinstance(node, Decorator) and node.func.is_property:`
	`7160`	`+ if isinstance(ctx, Decorator) and isinstance(node, Decorator) and node.func.is_property:`
`7161`	`7161`	`self.note("Property setter and deleter must be adjacent to the getter.", ctx)`
`7162`	`7162`
`7163`	`7163`	`def name_already_defined(`