use comprehension instead of map

randolf-scholz · randolf-scholz · commit 6720ffeb1874 · 2025-08-07T17:23:07.000+02:00
diff --git a/mypy/typeops.py b/mypy/typeops.py
@@ -602,7 +602,7 @@ def make_simplified_union(
         simplified_set = try_contracting_literals_in_union(simplified_set)
 
     # Step 5: Combine Literals and Instances with LKVs, e.g. Literal[1]?, Literal[1] -> Literal[1]?
-    proper_items: list[ProperType] = list(map(get_proper_type, simplified_set))
+    proper_items: list[ProperType] = [get_proper_type(t) for t in simplified_set]
     last_known_values: list[LiteralType | None] = [
         p_t.last_known_value if isinstance(p_t, Instance) else None for p_t in proper_items
     ]

Original file line number	Diff line number	Diff line change
`@@ -602,7 +602,7 @@ def make_simplified_union(`
`602`	`602`	`simplified_set = try_contracting_literals_in_union(simplified_set)`
`603`	`603`
`604`	`604`	`# Step 5: Combine Literals and Instances with LKVs, e.g. Literal[1]?, Literal[1] -> Literal[1]?`
`605`		`- proper_items: list[ProperType] = list(map(get_proper_type, simplified_set))`
	`605`	`+ proper_items: list[ProperType] = [get_proper_type(t) for t in simplified_set]`
`606`	`606`	`last_known_values: list[LiteralType \| None] = [`
`607`	`607`	`p_t.last_known_value if isinstance(p_t, Instance) else None for p_t in proper_items`
`608`	`608`	`]`