pivot to --enable-all-error-codes flag

per the advice of the discussors of the github issue

Author: wyattscarpenter

mypy/main.py

@@ -953,6 +953,11 @@ def add_invertible_flag(
         default=[],
         help="Enable a specific error code",
     )
+    strictness_group.add_argument(
+        "--enable-all-error-codes",
+        action="store_true",
+        help="Enable all error codes",
+    )
 
     error_group = parser.add_argument_group(
         title="Configuring error messages",

mypy/options.py

@@ -254,6 +254,7 @@ def __init__(self) -> None:
         # Error codes to enable
         self.enable_error_code: list[str] = []
         self.enabled_error_codes: set[ErrorCode] = set()
+        self.enable_all_error_codes = False
 
         # Use script name instead of __main__
         self.scripts_are_modules = False
@@ -451,7 +452,7 @@ def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None:
             error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_codes))}")
 
         self.disabled_error_codes |= {error_codes[code] for code in disabled_codes}
-        if "all" in enabled_codes:
+        if self.enable_all_error_codes:
             self.enabled_error_codes = set(error_codes.values())
         else:
             self.enabled_error_codes |= {error_codes[code] for code in enabled_codes}

test-data/unit/check-flags.test

@@ -2468,8 +2468,8 @@ A = Union[C, List]  # OK
 def f():
     x: int = "no"  # N: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs
 
-[case testSpotCheckErrorCodeAll]
-# flags: --enable-error-code all
+[case testSpotCheckEnableAllErrorCodes]
+# flags: --enable-all-error-codes
 # It would be annoying to check every error here, so let's just check a couple.
 from typing_extensions import override
 
@@ -2489,13 +2489,12 @@ class Child(Parent):
         pass
 [builtins fixtures/tuple-simple.pyi]
 
-[case testSpotCheckErrorCodeAllNotUsed]
+[case testSpotCheckEnableAllErrorCodesNot]
 # This test case exists purely to ensure that the testSpotCheckErrorCodeAll test does not become obsolete.
 # (For example, if all the errors expected by testSpotCheckErrorCodeAll get turned on by default, then
 #  the testSpotCheckErrorCodeAll test would fail to guarantee the enablement of any additional errors!
 #  (hint: if that does happen, breaking this test, then consider changing these two tests to pick *different*,
 #   not-enabled-by-default, error codes.))
-
 from typing_extensions import override
 
 class Parent:

test-data/unit/fixtures/tuple-simple.pyi

@@ -20,5 +20,5 @@ class int: pass
 class str: pass # For convenience
 class dict: pass
 
-# Had to define this testSpotCheckErrorCodeAll*, for whatever reason:
+# Had to define this for testSpotCheckErrorCodeAll*, for whatever reason:
 class ellipsis: pass